Add gas limit check to sequencer tx #332

* feat: feynman mainnet ts Signed-off-by: Gregory Edison <[email protected]> * chore: update mainnet feynman fork time Signed-off-by: Gregory Edison <[email protected]> * chore: fix clippy docs (paradigmxyz#17726) Co-authored-by: Alexey Shekhirin <[email protected]> --------- Signed-off-by: Gregory Edison <[email protected]> Co-authored-by: Matthias Seitz <[email protected]> Co-authored-by: Alexey Shekhirin <[email protected]>

…digmxyz#17784) Co-authored-by: Matthias Seitz <[email protected]>

…adigmxyz#17756) Co-authored-by: Matthias Seitz <[email protected]>

Signed-off-by: Gregory Edison <[email protected]>

…ll fee parameters (#320) * feat: use from_custom_genesis for custom genesis files and set Scroll fee parameters * fix CI * address a comment

Signed-off-by: Gregory Edison <[email protected]>

* fix(network): off by one error in getting next header * fix CI * fix CI * fix CI * fix CI * fix CI * revert * revert

* feat: limit rollup fee in tx pool Signed-off-by: Gregory Edison <[email protected]> * fix: check rollup fee Signed-off-by: Gregory Edison <[email protected]> * feat: limit pool tx size (#317) * feat: add maxTxPayloadBytesPerBlock to ScrollChainConfig Signed-off-by: Gregory Edison <[email protected]> * feat: limit pool max tx input bytes Signed-off-by: Gregory Edison <[email protected]> * test: set max_tx_payload_bytes_per_block Signed-off-by: Gregory Edison <[email protected]> * feat: make MockEthProvider more generic Signed-off-by: Gregory Edison <[email protected]> * test: add pool limit tests Signed-off-by: Gregory Edison <[email protected]> * fix: lints Signed-off-by: Gregory Edison <[email protected]> --------- Signed-off-by: Gregory Edison <[email protected]> * test: update Signed-off-by: Gregory Edison <[email protected]> --------- Signed-off-by: Gregory Edison <[email protected]>

chore: merge upstream bcbd2d6

* feat: block validation Signed-off-by: Gregory Edison <[email protected]> * feat: header validation Signed-off-by: Gregory Edison <[email protected]> * feat: body validation Signed-off-by: Gregory Edison <[email protected]> * feat: withdraw trie root slot (#312) * feat: update execute_with_state_closure closure Signed-off-by: Gregory Edison <[email protected]> * feat: LoadWithdrawRoot Signed-off-by: Gregory Edison <[email protected]> * chore: fix clippy docs (paradigmxyz#17726) Co-authored-by: Alexey Shekhirin <[email protected]> * fix: clippy Signed-off-by: Gregory Edison <[email protected]> --------- Signed-off-by: Gregory Edison <[email protected]> Co-authored-by: Matthias Seitz <[email protected]> Co-authored-by: Alexey Shekhirin <[email protected]> * chore: reorg Signed-off-by: Gregory Edison <[email protected]> * feat: answer comment + add unit test Signed-off-by: Gregory Edison <[email protected]> * feat: answer comment Signed-off-by: Gregory Edison <[email protected]> * feat: check sequential L1 message post EuclidV2 Signed-off-by: Gregory Edison <[email protected]> --------- Signed-off-by: Gregory Edison <[email protected]> Co-authored-by: Matthias Seitz <[email protected]> Co-authored-by: Alexey Shekhirin <[email protected]> Co-authored-by: frisitano <[email protected]>

* feat: limit rollup fee in tx pool Signed-off-by: Gregory Edison <[email protected]> * fix: check rollup fee Signed-off-by: Gregory Edison <[email protected]> * feat: limit pool tx size (#317) * feat: add maxTxPayloadBytesPerBlock to ScrollChainConfig Signed-off-by: Gregory Edison <[email protected]> * feat: limit pool max tx input bytes Signed-off-by: Gregory Edison <[email protected]> * test: set max_tx_payload_bytes_per_block Signed-off-by: Gregory Edison <[email protected]> * feat: make MockEthProvider more generic Signed-off-by: Gregory Edison <[email protected]> * test: add pool limit tests Signed-off-by: Gregory Edison <[email protected]> * fix: lints Signed-off-by: Gregory Edison <[email protected]> --------- Signed-off-by: Gregory Edison <[email protected]> * test: update Signed-off-by: Gregory Edison <[email protected]> * feat: disallow L1 messages in tx pool Signed-off-by: Gregory Edison <[email protected]> * test: disallow L1 messages in tx pool Signed-off-by: Gregory Edison <[email protected]> --------- Signed-off-by: Gregory Edison <[email protected]> Co-authored-by: frisitano <[email protected]>

* export ScrollEngineValidatorBuilder * export ScrollNodeTypes * update dev genesis

github-actions · 2025-08-29T10:05:24Z

Your PR title doesn't follow the Conventional Commit guidelines.

Example of valid titles:

feat: add new user login
fix: correct button size
docs: update README

Usage:

feat: Introduces a new feature
fix: Patches a bug
chore: General maintenance tasks or updates
test: Adding new tests or modifying existing tests
bench: Adding new benchmarks or modifying existing benchmarks
perf: Performance improvements
refactor: Changes to improve code structure
docs: Documentation updates
ci: Changes to CI/CD configurations
revert: Reverts a previously merged PR
deps: Updates dependencies

Breaking Changes

Breaking changes are noted by using an exclamation mark. For example:

feat!: changed the API
chore(node)!: Removed unused public function

Help

For more information, follow the guidelines here: https://www.conventionalcommits.org/en/v1.0.0/

codspeed-hq · 2025-08-29T10:15:26Z

CodSpeed Performance Report

Merging #332 will not alter performance

_{Comparing add_gas_limit_check_to_sequencer_tx (2480600) with scroll (d485f47)¹}

Summary

✅ 77 untouched benchmarks

No successful run was found on main (02824da) during the generation of this report, so scroll (d485f47) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

cakevm and others added 30 commits July 15, 2025 09:20

feat(alloy-provider): implement header methods (paradigmxyz#17402)

13c59dc

feat(sdk): make engine API (auth server) optional for custom consensu…

00d259d

…s integrations (paradigmxyz#17376)

chore(txpool): use alloy-primitives HashMap for SenderIdentifiers (pa…

c667bc9

…radigmxyz#17408)

feat: Add support for ethstats (paradigmxyz#16396)

fb9f3cc

Co-authored-by: Matthias Seitz <[email protected]>

refactor: BlindedPovider rename (paradigmxyz#17208)

fe1d2d2

Signed-off-by: Aliaksei Misiukevich <[email protected]> Co-authored-by: Alexey Shekhirin <[email protected]>

chore: box import future (paradigmxyz#17424)

55fa57b

refactor: use DefaultTrieNodeProviderFactory in state root calculation (

4364cd0

paradigmxyz#17425)

test(engine): enable parallel sparse trie in e2e tests (paradigmxyz#1…

cd73705

…7423)

chore: add txpool submit examples (paradigmxyz#17420)

5d72088

chore(consensus): refactor fork and ommers check into standalone fn (p…

76b19f3

…aradigmxyz#17406)

refactor: remove unused sparse trie methods (paradigmxyz#17433)

b0d05b6

Co-authored-by: Claude <[email protected]>

chore: bump revm 273 (paradigmxyz#17412)

2643324

feat: make revm_spec generic over header type (paradigmxyz#17436)

8e5efb3

chore: simplify blob count extraction using new blob_count() method (p…

1179da2

…aradigmxyz#17439)

chore(bin): missing --jwt-secret message in reth-bench (paradigmxyz…

c01f230

…#17443)

fix: Rename WitnessBlindedProvider to WitnessTrieNodeProvider (paradi…

8cbd119

…gmxyz#17426)

fix: Update Docker Compose Docs Link in etc/README.md (paradigmxyz#17414

fdefed3

)

fix: rename highest_static_fileted_block to `highest_static_file_bl…

2d1f8cd

…ock` (paradigmxyz#17427)

docs: enhance direct database access documentation (paradigmxyz#17445)

f86959f

Co-authored-by: Claude <[email protected]>

fix: Update JWT Secret Flag in Benchmark Documentation (paradigmxyz#1…

825222f

…7447)

perf(trie): parallelize ParallelSparseTrie::reveal_nodes (paradigmxyz…

802be64

…#17372)

docs: fix typo in NetworkManager diagram (paradigmxyz#17448)

1e20871

feat: make engine API metered methods and utilities public (paradigmx…

824e099

…yz#17460)

chore: correct spelling errors (paradigmxyz#17462)

2afd109

refactor: move receipt conversions to RpcConverter (paradigmxyz#17450)

7ccb37e

docs: fix typo from optstack to opstack (paradigmxyz#17454)

237e97a

feat(tx-pool): add submit methods to TransactionPool (paradigmxyz#1…

0b1d950

…7431)

feat(alloy-provider): implement sealed_header method (paradigmxyz#1…

61a19c1

…7455)

feat: add helper for building pending block env (paradigmxyz#17464)

05fed6f

fix: use primitives headers for pruner (paradigmxyz#17458)

425541d

georgehao and others added 27 commits August 11, 2025 08:42

docs: remove deprecated difficulty check comment (paradigmxyz#17781)

31dd133

chore(deps): weekly cargo update (paradigmxyz#17777)

6260c10

Co-authored-by: github-merge-queue <[email protected]> Co-authored-by: Matthias Seitz <[email protected]>

fix(network): push header before next header check in `get_headers_re…

42ae8be

…sponse` (paradigmxyz#17766) Co-authored-by: Matthias Seitz <[email protected]>

fix: reth dev node implement the --block-max-transactions arg (para…

1ba9e68

…digmxyz#17784) Co-authored-by: Matthias Seitz <[email protected]>

docs: add optimism Access-list spec (paradigmxyz#17775)

69a1951

chore: replace ~/.cargo with $CARGO_HOME (paradigmxyz#17776)

76c4c02

fix: push header before limit check in get_headers_response (#318)

74dd0bd

feat: persist origin on pooled tx backup for propagation setting (par…

3e0ceda

…adigmxyz#17756) Co-authored-by: Matthias Seitz <[email protected]>

feat: add op db access example (paradigmxyz#17796)

0b1c94a

chore: remove redundant words in comment (paradigmxyz#17753)

3ba2370

chore: Expose payload builder handle and metrics (paradigmxyz#17764)

bcbd2d6

update fork base commit

a3fe9e8

Signed-off-by: Gregory Edison <[email protected]>

chore: reconcile merge

323f2af

Signed-off-by: Gregory Edison <[email protected]>

feat: update addon and engine API

84fd09f

Signed-off-by: Gregory Edison <[email protected]>

feat: replace IntoTxEnv by ToTxEnv

aa053e7

Signed-off-by: Gregory Edison <[email protected]>

feat: use from_custom_genesis for custom genesis files and set Scro…

40affdf

…ll fee parameters (#320) * feat: use from_custom_genesis for custom genesis files and set Scroll fee parameters * fix CI * address a comment

feat: update openvm workflow

8053981

Signed-off-by: Gregory Edison <[email protected]>

ci: update env for openvm

2c1a1f2

Signed-off-by: Gregory Edison <[email protected]>

fix(network): off by one error in getting next header (#323)

85a5d1d

* fix(network): off by one error in getting next header * fix CI * fix CI * fix CI * fix CI * fix CI * revert * revert

Merge pull request #321 from scroll-tech/chore-merge-upstream-bcbd2d64c

619f42f

chore: merge upstream bcbd2d6

fix lints (#325)

3b4a3c3

feat: rollup node integration (#328)

d485f47

* export ScrollEngineValidatorBuilder * export ScrollNodeTypes * update dev genesis

add gaslimit check for execute_sequencer_transactions

2480600

georgehao closed this Aug 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add gas limit check to sequencer tx #332

Add gas limit check to sequencer tx #332

Uh oh!

georgehao commented Aug 29, 2025

Uh oh!

github-actions bot commented Aug 29, 2025

Uh oh!

codspeed-hq bot commented Aug 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Add gas limit check to sequencer tx #332

Add gas limit check to sequencer tx #332

Uh oh!

Conversation

georgehao commented Aug 29, 2025

Uh oh!

github-actions bot commented Aug 29, 2025

Uh oh!

codspeed-hq bot commented Aug 29, 2025

CodSpeed Performance Report

Merging #332 will not alter performance

Summary

Footnotes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants